Skip to content

[SC-10335] Repo Sync repo-sync/7325 (2025-06-27)#387

Merged
nrichers merged 1 commit intomainfrom
repo-sync/7325
Jul 3, 2025
Merged

[SC-10335] Repo Sync repo-sync/7325 (2025-06-27)#387
nrichers merged 1 commit intomainfrom
repo-sync/7325

Conversation

@eggshell
Copy link
Contributor

Repo Sync repo-sync/7325 (2025-06-27

@eggshell eggshell added the internal Not to be externalized in the release notes label Jun 27, 2025
@github-actions
Copy link
Contributor

PR Summary

This pull request updates the regular expressions used in the release notes check script to improve flexibility and case sensitivity. The changes include:

  • Modifying the regex pattern to optionally match the word "External" before "Release Notes" so that both "## Release Notes" and "## External Release Notes" headers are processed correctly.
  • Adding the IGNORECASE flag to the regex, making the matching process case-insensitive.

These enhancements ensure that the CI process correctly identifies valid release notes regardless of slight variations in the header text, leading to more robust release note verification in pull requests.

Test Suggestions

  • Create PR descriptions with both '## Release Notes' and '## External Release Notes' headers to ensure both forms are correctly matched.
  • Test with varying cases (e.g., '## external release notes', '## RELEASE NOTES') to verify case insensitivity.
  • Include a scenario with missing or placeholder release notes text to ensure the CI check returns false as expected.
  • Test with additional markdown sections following the release notes to ensure the regex stops at the right point.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@nrichers nrichers merged commit a5f530c into main Jul 3, 2025
8 checks passed
@nrichers nrichers deleted the repo-sync/7325 branch July 3, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants